search

Rightpoint / RZUtils

Rightpoint Commonly Used Tools
Other
123 stars 22 forks source link

Method for getting enumified screen height. #65

Closed jkaufman closed 10 years ago

jkaufman commented 10 years ago

@Raizlabs/maintainers-ios Feedback welcome. This method is an alternative to the raft of device-specific macros out there for conditional layout, such as IS_IPHONE5, that won't survive the addition of a third phone screen size.

ZevEisenberg commented 10 years ago

This is a cool idea. I would hold off on merging until we find out whether Apple is going to include something like this by default.

jkaufman commented 10 years ago

Can't hurt to hope, but they didn't provide anything similar for the iPhone 5 transition.

Edit: This at least earns us backwards compatibility.

ndonald2 commented 10 years ago

@jkaufman @ZevEisenberg With the new size class stuff, is there any value in this?

ZevEisenberg commented 10 years ago

@ndonald2 backwards compatibility. New size classes don’t work on iOS 7 afaik.

ndonald2 commented 10 years ago

Might still be worth waiting to see how the ecosystem evolves, now that it looks highly likely that resizeable apps will be a thing.

jkaufman commented 10 years ago

Given the large delta to size classes, I'd suggest we let this go. We'll cook something up that maps more closely once we have the need.

jkaufman commented 10 years ago

@Raizlabs/maintainers-ios I propose we decline the pull request, closing it and deleting the branch.

ndonald2 commented 10 years ago

@jkaufman I think that's fine. AFAIK nobody is using this in any projects. Closing now.