search

Rightpoint / RZVinyl

Stack management, ActiveRecord utilities, and seamless importing for Core Data
Other
21 stars 6 forks source link

don't log to console when there are no changes #62

Closed mr-fixit closed 8 years ago

mr-fixit commented 8 years ago

addresses #61

ZevEisenberg commented 8 years ago

? Any practical way to unit test this?

jwatson commented 8 years ago

@ZevEisenberg I can't think of any way to test this that actually tests the code in question. Unless you've thought of something, I'm inclined to merge this as-is.

ZevEisenberg commented 8 years ago

Make it so.

KingOfBrian commented 8 years ago

I know I'm late to the party here, but it seems over-kill to add an options object to conditionally log a message of limited use.

A configurable logger would be easy to implement. I did this in RZBluetooth which doesn't make it depend on a logger and should be easy to integrate with other loggers:

https://github.com/Raizlabs/RZBluetooth/blob/master/RZBluetooth/RZBLog.h

KingOfBrian commented 8 years ago

So I went to take a stab at this and implement an external logger, but in reality, this is the only message that might want to be configurable.

I'd like to just remove the log message rather than add a configurable option just due to expanding the public API for such a small nuance. I also realized that using the existing core data stack options would be another way to obtain the same feature with less API expansion. I still think I'd prefer to just delete the log message, but #73 is another option for consideration.

jwatson commented 8 years ago

This will be dealt with in #73.