Actionable Improvements

nevillco commented 6 years ago

In working on a client project, we have Services that require delegation and would benefit from Actionable. We soon realized:

The Services framework does not include Actionable
Even if it did, the existing implementation breaks for non-internal types

This PR:

Tweaks the Actionable template to use the access control of the implementing type
Moves "utility" functions into a new Actionable+Helpers.swifttemplate file for readability
Adds a Sourcery build phase to the Services target, and moves the template files (which are now shared between targets) to Services

Allows for nested Actionable types. Prior to this PR, the following code would cause Sourcery to generate non-compiling code:

class Foo {
class Bar: Actionable {
    weak var delegate: Delegate?
    enum Action {
        case baz
    }
}
}

Now, it generates:


// MARK: - Foo.Bar
internal protocol FooBarDelegate: class {

func bar(_ component: Foo.Bar, didNotify action: Foo.Bar.Action)

}

internal extension Foo.Bar {

typealias ActionType = Action
typealias Delegate = FooBarDelegate

func notify(_ action: ActionType) {
    delegate?.bar(self, didNotify: action)
}

func with(delegate: Delegate) -> Self {
    self.delegate = delegate
    return self
}

}

raizlabs-oss-bot commented 6 years ago

	1 Warning
:warning:	Big PR

	4 Messages
:book:	Test Results
:book:	Code Coverage: xcov
:book:	Code Coverage: Slather
:book:	Screenshots

Current coverage for Services.framework is `63.40%`

Files changed	-	-
Actionable.swift	`0.00%`	:skull:

Current coverage for debug-PRODUCTNAME.app is `1.81%`

Files changed	-	-
Actionable.swift	`0.00%`	:skull:
Actionable+AutoConformance.swift	`0.00%`	:skull:

Powered by xcov

Generated by :no_entry_sign: Danger

heyltsjay commented 6 years ago

@nevillco Agreed that we shouldn't duplicate the template files. I would be ok with them living in their Services home if you can pull off the generation. Or perhaps an alias can help.

nevillco commented 6 years ago

@heyltsjay Done - template files are living in Services

nevillco commented 5 years ago

Closing in favor of #116

Rightpoint / ios-template