search

Rightpoint / ios-template

A `cookiecutter` template for iOS projects
MIT License
94 stars 26 forks source link

Replace Marshal with Codable #122

Closed chrisballinger closed 5 years ago

chrisballinger commented 5 years ago

Blocked on #119 to be merged

TODO:

Resolves #120

raizlabs-oss-bot commented 5 years ago
1 Warning
:warning: Big PR
4 Messages
:book: Test Results
:book: Code Coverage: xcov
:book: Code Coverage: Slather
:book: Screenshots

Current coverage for Services.framework is 67.51%

Files changed - -
RequestProtocol.swift 0.00% :skull:
APIEndpoint.swift 25.00% :no_entry_sign:
APIClient.swift 66.67% :warning:
Alamofire+PRODUCTNAME.swift 73.44% :warning:
APISerialization.swift 74.29% :warning:
APIEndpoint+Logging.swift 76.19% :warning:
OAuth.swift 77.44% :warning:
APIValidation.swift 86.67% :white_check_mark:
APIError.swift 100.00% :white_check_mark:
Keychain+Codable.swift 100.00% :white_check_mark:
APIEndpoint+Codable.swift 100.00% :white_check_mark:
Formatters.swift 100.00% :white_check_mark:

Current coverage for debug-PRODUCTNAME.app is 0.78%

Files changed - -
AuthCoordinator.swift 0.00% :skull:
UIColor+Extensions.swift 0.00% :skull:
AnalyticsPageNames.swift 0.00% :skull:
GoogleAnalytics.swift 0.00% :skull:

Powered by xcov

Generated by :no_entry_sign: Danger

ZevEisenberg commented 5 years ago

(I should have added that I personally prefer uncuddled else, and that’s what we’ve tended to use as our default for projects, but picking one and sticking with it is more important than which style we choose, IMHO, and it’s still up to the project owner.)

chrisballinger commented 5 years ago

My opinion is that "else cuddling" style is up to the consensus of each project team, and shouldn't necessarily be prescribed by the template. SwiftLint's default setting for "cuddled else" matches the style used by Swift's standard library and Apple's sample code, so generally I prefer to match those style conventions.

The main reason I changed it was because the code I was back-porting used the "cuddled else" style. If it helps get this merged, I can set it back to the template's original behavior though and run it through autocorrect.