Rightpoint / ios-template

A `cookiecutter` template for iOS projects
MIT License
94 stars 26 forks source link

Move BUILD_NUMBER=1 up to global config #136

Closed ZevEisenberg closed 5 years ago

ZevEisenberg commented 5 years ago

Currently, we have BUILD_NUMBER=1 in Debug.xcconfig. This is to placate Xcode, which validates that the app has a valid build number when running in the simulator. During a real build, Fastlane generates and injects a build number.

We should move the local override up to Global.xcconfig so it applies to all schemes, not just the Debug scheme. The build number will still be overridden by the argument passed in by Fastlane, so this would just make it possible to run the other schemes on the simulator.

Credit to @chrisballinger with the idea.

minimusic commented 5 years ago

Done in: https://github.com/Rightpoint/ios-template/pull/137