search

Rightpoint / ios-template

A `cookiecutter` template for iOS projects
MIT License
94 stars 26 forks source link

temp 139 color asset catalog [WIP] #144

Open minimusic opened 5 years ago

minimusic commented 5 years ago

Moved all colors into new Colors.xcassets catalog. If built under iOS 13 SDK, fully supports dark mode. Once we are ready to force building under iOS 13 SDK, we can add a mechanism to opt for using new system colors if available, but for this PR I'm keeping project buildable on iOS 12 so we can merge now.

raizlabs-oss-bot commented 5 years ago
1 Warning
:warning: Big PR
4 Messages
:book: Test Results
:book: Code Coverage: xcov
:book: Code Coverage: Slather
:book: Screenshots

Current coverage for Services.framework is 67.51%

Files changed - -
RequestProtocol.swift 0.00% :skull:
APIClient+PRODUCTNAME.swift 0.00% :skull:
APIEndpoint.swift 25.00% :no_entry_sign:
APIClient.swift 66.67% :warning:
Alamofire+PRODUCTNAME.swift 73.44% :warning:
APISerialization.swift 74.29% :warning:
APIEndpoint+Logging.swift 76.19% :warning:
OAuth.swift 77.44% :warning:
APIValidation.swift 86.67% :white_check_mark:
APIEnvironment.swift 100.00% :white_check_mark:
Keychain+Codable.swift 100.00% :white_check_mark:
BuildType.swift 100.00% :white_check_mark:
APIError.swift 100.00% :white_check_mark:
Formatters.swift 100.00% :white_check_mark:
APIEndpoint+Codable.swift 100.00% :white_check_mark:

Current coverage for debug-PRODUCTNAME.app is 0.78%

Files changed - -
SignInCoordinator.swift 0.00% :skull:
OnboardingCoordinator.swift 0.00% :skull:
OnboardingPageViewController.swift 0.00% :skull:
InstabugConfiguration.swift 0.00% :skull:
LoggingConfiguration.swift 0.00% :skull:
StringStyle+PRODUCTNAME.swift 0.00% :skull:
DebugTextStyleViewController.swift 0.00% :skull:
TableDataSource.swift 0.00% :skull:
UIColor+Extensions.swift 0.00% :skull:
AuthCoordinator.swift 0.00% :skull:
OnboardingSamplePageViewController.swift 0.00% :skull:
ModalDismissBehavior.swift 0.00% :skull:
StatusBarConfiguration.swift 0.00% :skull:
SimpleTableCellItem.swift 0.00% :skull:
DebugMenuViewController.swift 0.00% :skull:
Appearance.swift 0.00% :skull:
ControlContainable.swift 0.00% :skull:
AnalyticsConfiguration.swift 0.00% :skull:
AppLifecycle.swift 0.00% :skull:
AnalyticsPageNames.swift 0.00% :skull:
Actionable.swift 0.00% :skull:
TableViewContainerCell.swift 0.00% :skull:
ContentTabBarViewController.swift 0.00% :skull:
ContentCoordinator.swift 0.00% :skull:
ViewRepresentable.swift 0.00% :skull:
ProcessInfo+Utilities.swift 0.00% :skull:
TableViewCellRepresentable.swift 0.00% :skull:
GoogleAnalytics.swift 0.00% :skull:
Analytics.swift 0.00% :skull:
TableSection.swift 0.00% :skull:
DebugMenu.swift 0.00% :skull:
TableCellItem.swift 0.00% :skull:
DebugMenuConfiguration.swift 0.00% :skull:
HideBackButtonTextBehavior.swift 0.00% :skull:
AppCoordinator.swift 0.00% :skull:
CrashlyticsConfiguration.swift 0.00% :skull:
AppDelegate.swift 21.43% :skull:
UserDefaults+Utilities.swift 50.00% :warning:

Powered by xcov

Generated by :no_entry_sign: Danger

minimusic commented 4 years ago

This has some merge conflict issues I'll fix and I might refactor with an example of using system colors when running on iOS 13

ZevEisenberg commented 4 years ago

@minimusic what’s the case for using separate asset catalogs for colors and images? I thought dark mode colors are just silently ignored on iOS < 13?

minimusic commented 4 years ago

@ZevEisenberg You CAN just mix all colors and images in the single main asset catalog, and it will function. The main advantage was keeping them grouped, and when exporting from Zeplin you can choose which asset catalog to target. I'm open to other options! We tried making a "Colors" folder in the main catalog, but Zeplin doesn't know about it so new colors needed to be manually dragged in (didn't test with SwiftGen, but that should find colors in a folder).