search

Rightpoint / ios-template

A `cookiecutter` template for iOS projects
MIT License
94 stars 26 forks source link

Fix #135 Bundle Identifier issue. #148

Closed mattwhitlock closed 4 years ago

mattwhitlock commented 4 years ago

Reordered replace command in generate_template to fix issue where bundle identifier would not be updated correctly.

Fixes #135

raizlabs-oss-bot commented 4 years ago
4 Messages
:book: Test Results
:book: Code Coverage: xcov
:book: Code Coverage: Slather
:book: Screenshots

Current coverage for Services.framework is 68.30%

✅ No files affecting coverage found

Current coverage for debug-PRODUCTNAME.app is 0.78%

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger

mattwhitlock commented 4 years ago

testAuthenticatedRequestWithCredentials test is passing locally in Xcode, command line and on test-xcode-10-2 in Circle CI but not in danger... Investigating.

mattwhitlock commented 4 years ago

Test fail most likely due to #123 OHHTTPStub Tests failing inconsistently. Will try to force rebuild. In the meantime, those tests may need to be commented out until that issue is tracked down and resolved.

mattwhitlock commented 4 years ago

Although all tests are passing and are fine to be merged, I believe Issue #123 is still present and more work is likely needed.

Tests as currently constructed are likely fine from the perspective of OHHTTPStubs. See https://github.com/AliSoftware/OHHTTPStubs/wiki/OHHTTPStubs-and-asynchronous-tests Either formulation (do XCTAssert() in waitForExpectations:timeout:handler or after wairForExpectations:timeout) should be fine there.

That leaves APIClient itself although it's a very light layer on top of Alamofire. Next step is probably to continue work on #123. I don't believe that should hold up merging this specific PR though as it's simply fixing a bundle identifier issue.

mattwhitlock commented 4 years ago

Closing as this template is no longer in active use.