search

Rigner / discord-rpc-java

Java implementation of Discord RPC for rich presence https://github.com/discordapp/discord-rpc
MIT License
25 stars 9 forks source link

Better error code handling #4

Open Rigner opened 6 years ago

Rigner commented 6 years ago

https://github.com/PSNRigner/discord-rpc-java/blob/master/src/main/java/net/rigner/discordrpc/ErrorCode.java https://github.com/PSNRigner/discord-rpc-java/blob/master/src/main/java/net/rigner/discordrpc/impl/RpcConnection.java#L193 https://github.com/PSNRigner/discord-rpc-java/blob/master/src/main/java/net/rigner/discordrpc/DiscordRpc.java#L328

Implement more error codes, with the use of an id instead of using the values array.

Notoh commented 6 years ago

I'll work on this soon, whenever I get time.

SirYwell commented 6 years ago

It looks like this issue is outdated atm. Is there any ongoing work @Notoh? And, due to the fact, that SUCCESS is not really an error code, I would recommend to change the name to ResponseCode.

Notoh commented 6 years ago

No work currently being done considering I've been extremely busy with exams and other projects, sorry about that.

techied commented 6 years ago

@PSNRigner close or modify?