RigoBlock / contracts

[DEPRECATED] directory of our contracts
Apache License 2.0
1 stars 0 forks source link

double check how dragoID is created #12

Closed gabririgo closed 6 years ago

gabririgo commented 6 years ago

dragoID is created as next from dragoCount()

this could lead to a potential overlap in id if a fund gets registered unless a blank fund is registered

check whether it would be appropriate to create it as id++, so that it sums from the last registered id

this need to be double checked, it might not be necessary

gabririgo commented 6 years ago

double checked and when a fund gets unregistered, the count is not affected, hence it works correctly. double check whether the pop contract has issues in estimating the network value before and after a deregitration

gabririgo commented 6 years ago

all fine with checks.