search

RigoBlock / contracts

[DEPRECATED] directory of our contracts
Apache License 2.0
1 stars 0 forks source link

add version in eventful as improvement #24

Closed gabririgo closed 6 years ago

gabririgo commented 6 years ago

in order to improve the experience, and be able to work with different eventful contracts in the future, we could add "version" in eventful contract, and add it as output in events

potentially it will allows reading events from older contracts more easily.

this would add some cost to any call, so we need to consider the tradeoff. Furthermore, we should really understand whether it is a useful piece of data

wnz99 commented 6 years ago

yes, makes sense.

gabririgo commented 6 years ago

created a constant VERSION, cannot add to events as this is a data we can cache anywhere and would potentially prevent execution (full stack depth). Closing for now.