search

RigoBlock / contracts

[DEPRECATED] directory of our contracts
Apache License 2.0
1 stars 0 forks source link

Aggiungere alteriori parametri al contratto Eventful #3

Closed wnz99 closed 6 years ago

wnz99 commented 6 years ago

Aggiungere ulteriori parametri al contratto Eventful, come ad esempio symbol.

Questo ci permettere di diminuire il numero di chiamate al network. A momento per ogni entry recuperata dagli eventi, e' necessario effettuare un'ulteriore chiamata per determinare il simbolo del Drago.

gabririgo commented 6 years ago

we must carefully evaluate potential attack/fail vectors on the eventful contract. In particular, we must analyze if a transaction would fail on a fund which has been unregistered. When a trader misbehaves, we have veto power and can exclude her from the proof of performance by unregistering the fund. This, however, poses a problem if one sends a transaction to the fund which passes props to the eventful. In fact, within the query to the registry to get name and symbol of a fund, could return blank, hence we must handle the error within the eventuful contract and at the same time test all potential attack vectors. Working on it

gabririgo commented 6 years ago

the addition might generate a stack overflow, will make some tests as soon as I'm done with current review

gabririgo commented 6 years ago

name and symbol have been added to events buy and sell. in fund creation they were already there. The ratio is that all other events can should/will ideally be queried from within a view of a pool, hence name and symbol should be in the current state of the dapp. Closing as it's been implemented, if need further parameters please ask. We will try and reorganize drago eventul in the future.