search

RigoBlock / contracts

[DEPRECATED] directory of our contracts
Apache License 2.0
1 stars 0 forks source link

different interface for vault and dragos creates issues in pop #6

Closed gabririgo closed 6 years ago

gabririgo commented 6 years ago

the interface of vault is different in the way the price is read from the contracts vault: getPrice() drago: getData()(3)

this results in the pop algorithm not being able to read either one or the other

hence we need to implement aggregated data in vault as well

gabririgo commented 6 years ago

requires quite some work on reorganizing global variables as structs, will dedicate required time asap

gabririgo commented 6 years ago

a good idea would be to generalize the interfaces (standardized functions) so that the interface is the same and further factories just need to comply to the standard. Finalizing new interfaces this week.

gabririgo commented 6 years ago

so far the APIs (interfaces) have been unified for view functions. Leaving it open as I want to think about the possibility to uniform the core functions as well, through the use of: ENUM and implement cases for different classes of funds. Might be better however to keep them separate. Still need to think about it.

gabririgo commented 6 years ago

Interfaces of core functions could be potentially the same, just some drago specific functions would not be implemented in the vaults. This adds to the cost of creating a vault without giving a particular benefit, as external classes of pools will only have to comply to the PUBLIC CONSTANT FUNCTION interfaces. Closing it as the view interfaces have been unified