Controller input processing depends on framerate

[ohlidalp]

If you press a controller key/button (including mouse buttons) many times in a row, chances are some presses will be ignored by the game. There are 2 reasons for that:

• The game evaluates key states in the rendering loop. That means, in short, if you drop to 1FPS, your keypress will only be registered once per second. In regular play, it's not rare to have a keypress missed due to an FPS spike. Fixing this would be a major change, the rendering would have to be moved to a background thread and the game loop on main thread would need to run a lot faster. Such a change would, however, greatly benefit physics in general and networking, so it'll eventually be done anyway.
• The game has a built-in "bounce timeout" of 0.2 second for any key press. It's defined here: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/utils/InputEngine.h#L519-L522. It's purpose is to limit toggling speed when the key is held for a longer time, but it also limits the maximum key press rate accepted by the game. This might be a bug tho.

[paroj]

Fixing this would be a major change

actually, it is fairly easy - you just need to change your input backend from a key-table to an event-queue. ImGui did that recently too: https://github.com/ocornut/imgui/issues/4921

SDL2 queues up events internally by default, OIS can do that too probably (maybe?)