Turn signal audio vs. blink delay.

[ohlidalp]

Presently our "turn signal" sound has 2 "clicks" in it (the light-up click and the go-down click) so inevitably the sound drifts away from the flares and dash indicators. It's even worse if user sets custom "blink delay" parameter.

Flip889#6304 on Discord provided split sound effect files: https://discord.com/channels/136544456244461568/409871728597139457/1046285600787025943. To make use of it, a code change is needed - instead of existing continuous turn_signal trigger which is on the whole time signal is active, we need a new trigger turn_signal_lit which is only on while the signal is lit - then we can leverage existing soundscript feature {start/stop}_sound.

[ohlidalp]

I found a related glitch in blinkers (turn signals) - if no such flares are installed, the dashboard lamps dont work. you hear ticking but see nothing. The reason is the blinking is actually controlled using per-flare "blink delay" parameter - it's optional but still applicable.

So what now? I can simply make the dash lamps blink using the default blinkdelay, but then it will break if anyone wants faster blinking flares. Should I add something like set_default_blinker_delay ? 😄

See on Discord: https://discord.com/channels/136544456244461568/409871728597139457/1230984983133425775