RigsOfRods / rigs-of-rods

Main development repository for Rigs of Rods soft-body physics simulator
https://www.rigsofrods.org
GNU General Public License v3.0
990 stars 175 forks source link

Camera FOV rework #3139

Open ohlidalp opened 3 months ago

ohlidalp commented 3 months ago

With this ticket I try to clear some confusion about adjusting FOV and the meaning of the slider(s) in Top Menubar UI.

The slider is actually context sensitive; We have multiple presets:

To start this off, I clarified and commented the code in Top Menubar (as well as related CameraManager code), and I added a combobox to select camera mode: obrazek

Note: having FOV stepped in whole numbers is sort of a convention; thing is, angle degrees aren't typical (base 10) numbers but base 60 numbers, meaning 1 Degree = 60 Angular Minutes. Using a float to represent FOV in degrees would be kind of bastardized, but I think I'll do it anyway.

ohlidalp commented 3 months ago

I analyzed how the smoothing works and added a slider for it. I didn't add smoothing anywhere, but all existing smoothed values were unified around this slider. Default value is 4.0 which is the same as before (although the code was finnicky so it may not be always in effect).

obrazek