search

RigsOfRods / rigs-of-rods

Main development repository for Rigs of Rods soft-body physics simulator
https://www.rigsofrods.org
GNU General Public License v3.0
1.03k stars 178 forks source link

Main Menu Tune Is Not In Mono, Error Silently Ignored #481

Open graysonk95 opened 8 years ago

graysonk95 commented 8 years ago

RoR.log says the following:

16:56:43: Loading WAV file main_menu_tune.wav 16:56:43: Invalid WAV file: the file needs to be mono, and nothing else. Will try to continue anyways ...

Dutchy15 commented 8 years ago

If somebody can send me the main menu tune I'll make a mono version and send it back. (just use Wetransfer I guess)

graysonk95 commented 8 years ago

It's in C:\Program Files (x86)\Rigs of Rods 0.4.5\resources\sounds.zip, appropriately named main_menu_tune.wav.

Hiradur commented 8 years ago

@Dutchy15 Thanks for the initiative but this would only be a workaround for the error message but wouldn't help with the root cause. RoR checks all sound files if they are mono and throws this error if they aren't (https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/audio/SoundManager.cpp#L439 ). This is because RoR was designed with ingame sounds, not music, in mind. Ingame sounds should always be mono. What's missing is a separation between music and ingame sounds. The main menu tune is played in stereo despite this error message and it should be easy to fix, but it's low priority for now.