Sun icon for entire day in several cities

RiiConnect24 / File-Maker

Generate data files for Wii Channels that have the latest news, forecast data, etc.

GNU Affero General Public License v3.0

68 stars 25 forks source link

Sun icon for entire day in several cities #52

Closed HilbertIdeals5 closed 2 years ago

HilbertIdeals5 commented 3 years ago

Short Description of Issue: Several cities on the Globe show the sun icon during the 12am-6am and 6pm-12pm sections.

Long Issue: The short description, plus this: I assume it's probably happening because the "Cold" condition uses the sun icon, but doesn't have day/night versions (as it says here). I first noticed this while checking several Southern cities during the snowstorm... Screen Shot 2021-02-15 at 2 40 53 PM ...and I also found this in other northern locations several days afterward. Screen Shot 2021-02-17 at 4 22 48 PM

Steps to Reproduce :

Go to the Wii Menu, and start the Forecast Channel.
Check the globe, browse around for any cities where the weather is "Cold", or might be cold.
When clicking on the Today/Tomorrow icon, there might be a sun in the 1st or 4th quarters.

HilbertIdeals5 commented 3 years ago

It's been 3 weeks 😧

larsenv commented 3 years ago

I apologize for not responding. This was overlooked. Is this issue still happening?

Btw, if you can, it would be nice if you could talk to me on Discord about these issues instead of GitHub issues. It's easier than talking about the issues here, and most of the RC24 community is on Discord.

You can find me and others at https://discord.gg/rc24

HilbertIdeals5 commented 3 years ago

OK then 👍🏼 Also, recently I couldn't find any cities with the same problem, but there were some in February.

HilbertIdeals5 commented 3 years ago

The bug's come up again!

This is for the South Pole, right now: HAFE01_2021-06-13_18-36-22

It might have something to do with the fact that the weather is "Cold": HAFE01_2021-06-13_18-36-26

This might also be the case for the "Hot" condition as well, so

larsenv commented 3 years ago

Is this really a bug?

We use the sun icon for "Hot" and "Cold" because the Forecast Channel does not have a more appropriate weather icon. Even when it's night. Thus, if it's hot or cold for 24 hours for some reason, the hourly forecast will be all sun.

There was an issue that I discovered where the hourly forecast was mostly wrong a few months ago, but I fixed that (you might have told me about it). We've been using AccuWeather's enterprise API since December which allows viewing of 6-hour forecasts.

HilbertIdeals5 commented 3 years ago

The previous one was probably the one where the forecast was shifted forward 6 hours. For this, if it's not a bug, then it's more of an appearance thing, because having the sun icon when it's nighttime looks like a mistaken forecast.