RiiConnect24 / RC24-Bot

Server bot for the RiiConnect24 Discord server that can store Wii friend codes to be added. | https://discord.gg/rc24
https://rc24.xyz/
MIT License
36 stars 7 forks source link

Commands are case sensitive. #40

Closed LexiHDev closed 7 years ago

LexiHDev commented 7 years ago

This should be relatively to fix, but I don't have enough knowledge about Ruby to make a proper PR.

spotlightishere commented 7 years ago

Define what part is case sensitive.. the arguments? the defined command itself? An example would help as well. :P

LexiHDev commented 7 years ago

https://i.imgur.com/G3sYb46.png Sorry it wasn't so clear, but commands themselves

spotlightishere commented 7 years ago

Are you sure that's the right screenshot? xP

If you mean !code vs !Code, as far as I know discordrb intends this to be this way. I don't know of an option to disable sensitivity. I could possibly create a separate function containing code and multiple commands running it however

LexiHDev commented 7 years ago

Hm, I assumed it'd be a simple make a string lowercase, but if discordrb is making that impossible then it'd be more of a mess to add, and probably not worth bothering with at all.

Also, yes, that IS the wrong screenshot. Xfce4-screenshot is acting like a buggy mess

LexiHDev commented 7 years ago

If you can find a way to do this without adding a bunch of lines, then I'll reopen this but yeaah, perhaps I was quick to assume that it'd be easy to do.

I'll stop making issues now, sorry

spotlightishere commented 7 years ago

Lol, you're fine. Commands are defined as


command(:name) do |event|
etc
end```

I could create capitalized versions of the names theoretically. Needs investigation.
therealprocyon commented 7 years ago

@spotlightishere regarding this: with @Seriell's commandrb you can do this more easily

spotlightishere commented 7 years ago

@therealprocyon While that may be true, I feel that converting to commandrb would end up being a pain due to rubocop and the size of certain commands. Event syntax wouldn't mix with commandrb.

Also Seriel said not to use it until it was much much more stable 😛

therealprocyon commented 7 years ago

Alright then, that's true. AFAIK commandrb is now a public gem.

Artuto commented 7 years ago

And what if we port this to JDA heh

spotlightishere commented 7 years ago

I'm legitimately considering it.

On Sun, Aug 6, 2017, 15:50 Artuto notifications@github.com wrote:

And what if we port this to JDA heh

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/fl0co/RC24-Bot/issues/40#issuecomment-320528303, or mute the thread https://github.com/notifications/unsubscribe-auth/AJluWNK8Bj0oOuGyv1YQiE8Wbo6F1cXJks5sVhj0gaJpZM4OufTR .

Artuto commented 7 years ago

lets see what happens http://m.imgur.com/gallery/7SpqkNB

spotlightishere commented 7 years ago

I think what's needed is a reimplementation of event listeners tbh. You're welcome to port but I'll never want to change it entirely to JDA.

(Sounds like a fun experiment)

On Sun, Aug 6, 2017, 15:56 Artuto notifications@github.com wrote:

lets see what happens http://m.imgur.com/gallery/7SpqkNB

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/fl0co/RC24-Bot/issues/40#issuecomment-320528672, or mute the thread https://github.com/notifications/unsubscribe-auth/AJluWJiAKuJ7hLwnwFzjTPRGZJO5dgsfks5sVhp0gaJpZM4OufTR .

Erisa commented 6 years ago

Oh god it actually did get converted as well this was the beginning of the end

spotlightishere commented 6 years ago

Oi :(

Erisa commented 6 years ago

"I'll never want to change it entirely to JDA." Suuuuuuurrrrrrrrrreeeeeeeeeeee