search

Riiskits / Riiskit-Child

A child theme for Riiskit.
MIT License
2 stars 1 forks source link

Clean up function.php #10

Open sigurdsvela opened 9 years ago

sigurdsvela commented 9 years ago

Move most, if not all functionality(definitely all), from functions.php to include files, and only have those includes/requires inside functions.php.

This issue is related to #4

halvardos commented 9 years ago

When removing visibility of functionality, an adverse effect is it´s easier to forget that the functionality exists. This requires better documentation and comments describing the functionality that we are 'hiding'.

Moving options that should be changed out of view is possibly wrong, but might also be an indication that having that option in the firs place is a mistake (e.g $content_width in functions.php)

sigurdsvela commented 9 years ago

"Hiding" functionality will definitely require better documentation, but that is required anyway. And by cleaning up files, the code will be more readable. But yeah, definitely, some functionality in function.php that there is a desire to move away, might be better left out all together.

But for example, when we have the new JS&CSS structure in place, I would strongly prefer if only the options for the including(what files, when and where) are visible, not the actual mechanism for how it includes the file