Rewrite management commands TEST DRIVEN

[RikSchoonbeek]

Rewrite m commands test driven way

• [x] save coinapi assets
• [ ] save_available_exchange_currencies
• [ ] save_available_exchange_trading_pairs

[RikSchoonbeek]

Now going to work on save_available_exchange_currencies

[RikSchoonbeek]

• [x] replace check_if_ticker_symbol_instance_exists with check_if_model_instance_exists

[RikSchoonbeek]

Now:

was working on get_data_from_exchange_api function in save_available_exchange_currencies_utils.py

and simultaneously on the method(s) that will test it

• created method: test_get_data_from_exchange_api, the description is good! but it focuses on get_data_from_exchange_api, and that may not be the function that fits the description of test_get_data_from_exchange_api. so maybe I need to replace get_data_from_exchange_api in test_get_data_from_exchange_api with another function

[RikSchoonbeek]

write tests for:

• [x] get_currency_name_through_ticker_symbol
• [x] get_kraken_currency_name
• [x] get_binance_currency_name
• [x] get_currency_name
• [x] get_binance_formatted_data
• [x] get_bittrex_formatted_data
• [x] get_kraken_formatted_data
• [ ] get_currency_name_from_user (MAYBE NOT TEST THIS)

[RikSchoonbeek]

write test for:

• [x] get_all_currencies_formatted_data

[RikSchoonbeek]

I have written tests for everything that can be tested.

didn't write tests for:

• get_currency_name_from_user
• for the functions in common.utils
• get_all_currencies_data

[RikSchoonbeek]

Now I want to run save_available_exchange_currencies

but I still get errors

[RikSchoonbeek]

It seems that the TickerSymbol symbols aren't unique.

Some currencies have the same symbols

Like: KEY HOT

So, I need to adjust my code in such a way that TickerSymbol.symbol doesn't have to be unique.

• [ ] add unique_together
• [ ] I may have to do something with making the query param for currency name for the TickerSymbol in update_save_ticker_symbol not case sensitive

[RikSchoonbeek]

NOW

TickerSymbol Removed unique=True from symbol Added unique_together = [['symbol', 'currency']]

Nu proberen of save_coinapi_assets kan lopen Just did, but gave error.

Also check previous comment

• [ ] get save_coinapi_assets to work
• [ ] add test to test_save_coinapi_assets: test if (allmost) all of it's crypto's are added to the DB if it's ran. I can use len() to get the total count of assets that it has. Then I can run the command. After that I can test if the DB contains allmost all of the assets (allmost, because I know some aren't added). So I can have it check with a % difference (like 97% needs to be added).
• [ ] I can do a similar thing in test_save_available_exchange_currencies for the currencies added from the three databases.

[RikSchoonbeek]

I am changing save_coinapi_assets, have rewritten a few things. Now it runs without error, but I am getting an unexpected result.

When save_coinapi_assets has finished, there are more TickerSymbol instances in the database than there are Currencies, which is weird, because there should be an equal amount.

Maybe it's not necessary to have Currency and TickerSymbol separate, and maybe I can just have ticker_symbol as a column in the Currency table.

[RikSchoonbeek]

Since I removed the TickerSymbol model, and changed the Currency model, I need to adjust the files for save_available_exchange_currencies as well

[RikSchoonbeek]

adjusted in save_available_exchange_currencies:

• removed update_save_ticker_symbol
• updated update_save_currency_instance to also add the Currency's ticker_symbol
• [x] update check_if_model_instance_exists to also be able to deal with the new situation
• [x] update save_currency_exchange_pk
• [ ] update

[RikSchoonbeek]

NOW Trying to get

save_available_exchange_currencies to work, I think I have adjusted all the files in save_available_exchange_currencies_utils, and now I am trying to update the test for it.

I was running the test, but I get an error I don't understand yet.