Open Rikj000 opened 2 years ago
Linking to issue: https://github.com/Rikj000/MoniGoMani/issues/236
Before continuing with my work, one question:
Do you really want to get rid of the following mgm-config
values?
min_weighted_signal_value
max_weighted_signal_value
search_threshold_weighted_signal_values
So far I kept them as default values if None were given on the individual signal. Both are valid concepts, just let me know what you prefer.
Do you really want to get rid of the following
mgm-config
values?
min_weighted_signal_value
max_weighted_signal_value
search_threshold_weighted_signal_values
So far I kept them as default values if None were given on the individual signal.
That's a good idea, to keep them as default values! :smile:
check this #247
In the current MoniGoMani implementation we are limited to only being able to adjust the search space for all weighted signals at once.
The idea here would be to make the search spaces for individual weighted signals easily configurable in
MoniGoManiHyperStrategy.py
.:black_square_button: Each weighted signal should have following settings:
min
max
threshold
type
So it will align with the new
protection_spaces
format.:black_square_button: Then we can just use following settings from
mgm-config
as default values, if no specific ones are added inMoniGoManiHyperStrategy.py
:min_weighted_signal_value
max_weighted_signal_value
search_threshold_weighted_signal_values
:black_square_button: Finally we should re-work the documentation for this
@raftersvk is currently working on this on his separation-of-signals-into-triggers-and-guards branch,
and it was already showing promising results!
Early POC example:![early_example](https://media.discordapp.net/attachments/825837226813685780/932203306397364224/unknown.png)