search

RikkaApps / Riru

Inject into zygote process
4.87k stars 567 forks source link

Riru App 23 reports versions 22-23 as not working or not installed. Riru modules (updated for 22+) don't work. #154

Closed dariusz-goc closed 3 years ago

dariusz-goc commented 3 years ago

Riru App 23 reports versions 22-23 as not working or not installed. Riru modules (updated for 22+) don't work. I'm using Android Oreo 8.1 (Resurrection Remix, Lineage OS based on Xiaomi Mi6). Riru 21.3 works fine. I tried all versions from riru 22 to 23 pre-release and they all give me that riru is not installed or enabled. Screenshot_Nova_Launcher_20201130-174246

Originally posted by @dariusz-goc in https://github.com/RikkaApps/Riru/issues/150#issuecomment-735928049

dariusz-goc commented 3 years ago

https://github.com/RikkaApps/Riru/issues/150#issuecomment-736176517

@RikkaW This screenshot is from app v23. This state is with all updated to the latest versions.

RikkaW commented 3 years ago

Please provide boot log (in short, start adb logcat during boot progress)

dariusz-goc commented 3 years ago

Do I need debug version of riru?

RikkaW commented 3 years ago

Not necessary.

dariusz-goc commented 3 years ago

Ok, this log is with Riru v23 - release (latest). Now the com.android.phone is crashing and device reboots indefinitely. riru23-release-bootloop.txt

RikkaW commented 3 years ago

tzdata file "/system/usr/share/zoneinfo/tzdata" was present but invalid!

This is the root reason. I don't think it is related to Riru.

dariusz-goc commented 3 years ago

Ok, I did update the tz magisk module in the meantime, thank you for helping me troubleshoot this. I will delete this module and update the log.

PS: please be patient with me and don't close this too early, the issue is real and I will provide logs.

dariusz-goc commented 3 years ago

riru23-release.txt

Ok, this log is with Riru v23 - release (latest), the state in the latest app is as in the first screenshot in the first comment of this issue, which is:

Riru not installed or not enabled. File contents: /data/adb/riru/dev_random: sUGAS2s /dev/riru_sUGAS2s not exist

RikkaW commented 3 years ago

From your log, Magisk modules are loaded after the zygote is started. Older versions of Riru restart zygote even for the first time, so it "works".

This is highly possible a long existed Magisk problem, something is blocking the whole process. Without full logcat (your log is not early enough) and kernal log, I can't make a conclusion.

dariusz-goc commented 3 years ago

I made this log with a phone connected to a pc, I restarted the phone and immediately entered the command to take a log, it showed "waiting for device" and the log starts from the moment my computer connected to the phone. Is there any other way to take logs? How to take kernel logs?

dariusz-goc commented 3 years ago

Hi, I can see you've added zygote restart workaround in v51, however I'm happy to tell you that magisk canary just updated to 21102 and it fixed the execution cue! I tested Riru v50 (without zygote restart) and now it's working fine for the latest magisk, so you can disable that workaround for magisk >= 21102 👍 Hopefully that will make the restart a bit quicker :)