Rikko1204 / pe

0 stars 0 forks source link

Intake year shortened to single digit #3

Open Rikko1204 opened 2 months ago

Rikko1204 commented 2 months ago

Problem: When I type intake year 0000, the intake is shortened to 0 when it should have been 1000

Screenshot 2024-04-19 161951.png

soc-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Being able to add students on intakes way before the University was even created.

image.png

This is a feature flaw as this should not be even possible as there are no students from the year 1880 as the school was not created then. UG also has no mention of this and only says that the intake year cannot be after current year.


[original: nus-cs2103-AY2324S2/pe-interim#2309] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is a very rare case, Since the requirement for intake is to have 4 digits numeric number , its very unlikely for someone to type 0000 accidentally. We will consider adding a lower bound for intak but as its quite subjective whether the professor knows someone who was in College before the lower bound of the application , so in this case Our application can't enforce a dynamic Bound for the Application as of now , but We will consider this in future for sure.

We already have a upper bound for the Intake which can't be more than the current Year.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This issue is not about non-sensible dates allowed to be keyed in, but rather the fact that the year 0000 will be shortened to 0.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]