search

RikomagicCloudsto / LRms

9 stars 2 forks source link

Complete rewrite of the beaconmaster script. #2

Closed TomBayne closed 2 months ago

TomBayne commented 2 months ago

Aiming to use a proper object oriented approach, with a modular design that can be expanded upon in the future.

This was something I threw together in an hour tonight as I was bored, hopefully it should work. I've unfortunately not got a device to test this code on, but all of the commands sent to the device are the same as your original code, so there's no reason why it wouldn't work :)

Let me know if you get any errors and I'll try to resolve them :)

RikomagicCloudsto commented 2 months ago

Wow! This looks great, looks way better than my chatGPT cobble 🤣

I'll give it a test run ASAP!

Thanks for your help on this!

On Fri, 6 Sept 2024, 22:21 Tom Bayne, @.***> wrote:

Aiming to use a proper object oriented approach, with a modular design that can be expanded upon in the future.

This was something I threw together in an hour tonight as I was bored, hopefully it should work. I've unfortunately not got a device to test this code on, but all of the commands sent to the device are the same as your original code, so there's no reason why it wouldn't work :)

Let me know if you get any errors and I'll try to resolve them :)

You can view, comment on, or merge this pull request online at:

https://github.com/RikomagicCloudsto/LRms/pull/2 Commit Summary

File Changes

(1 file https://github.com/RikomagicCloudsto/LRms/pull/2/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/RikomagicCloudsto/LRms/pull/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGY3FAVF57LHZE5GONFOZ3ZVIMHPAVCNFSM6AAAAABNZKC5T2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTCMRRGA2TAMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

TomBayne commented 2 months ago

Rewrote the other files too.

TomBayne commented 2 months ago

Tbh this is still not well designed. In theory we should abstract the program into the following independent modules:

This way each 'function' is independent, and can be worked on individually from other functionality of the software. There is potentially ways to even further abstract each part of the functionality of the software, but these are my preliminary thoughts.

TomBayne commented 2 months ago

Closing this PR for now as I work on my own fork. I'll create a new PR when more progress is made. Things are going well so far 🎉