Rikshy / ModularItemFrame-Fabric

One Frame to rule them all
GNU General Public License v3.0
1 stars 2 forks source link

Some issues I've encountered so far #8

Open Samekichi opened 4 years ago

Samekichi commented 4 years ago

Playing under Fabric API 0.18.0 / 0.19.0, Fabric Loader 0.9.2, and Nbt Crafting-2.0.0-rc.2+mc1.16.2-pre1.

  1. For Teleport Module,
    • Player's inventory and hot bar will be temporarily cleared once going through it. Items in the slot not overwritten after that can be restored by reentering the world or changing dimensions, but items in the slots being refreshed (e.g. putting an item into that slot) will lose forever. For hot bar, putting an item into one slot and then put it into another slot will lose all items in hot bar instead of only losing the ones in the two operated slots.
    • If one linked teleport module is removed or broken and only a module frame is placed at that position, players can still teleport to that position through the other one for once. After that, the remaining one will have no reaction when RC under Fabric API 0.18.0, and is still able to teleport under 0.19.0.
  2. For Crafting Module,
    • Players can get ghost items from its GUI into inventory or hot bar if they close the GUI quickly enough (otherwise the ghost blocks seem to be deleted regularly), and those blocks will vanish when using, dropping, or reopening Crafting Module's GUI in survival mode. In creative mode under Fabric API 0.19.0, block count won't decrease during placing or dropping (probably just because placing blocks won't consume them in Creative), but both actions will have no effect, and items will still be deleted after reopening GUI. However, Creative under Fabric API 0.18.0 will make those blocks valid ones that can be used normally, which is like a meaningless duplicate method lol.
  3. For Tank Module,
    • The Input/Output feature seems not to work properly. It might be my misunderstanding on how to use it, but nothing happened after I attach two tank modules on two vertically placed blocks/containers on their same side, with the upper one in Output mode full of water and the other in Input/None mode left empty.
    • After using the Speed Upgrade, liquid filling into the frame will not increase its liquid level.
  4. For Item Group in Creative tabs,
    • The mod's tab seems to overwrite the vanilla decorative blocks tab.
Rikshy commented 4 years ago

Thanks for your feedback.

  1. will look into it
  2. I knew about this behaviour. tbh I have had a hard time with the ghost item stuff, but I will manage.
  3. So, frames don't interact with each other only the blocks the frame is placed on. Tbh, I didn't really test this feature myself afaik since there is no block considered a 'tank' in vanilla. This also goes for the fluid dispenser module.
  4. I noticed it being in that place, thought the decorative tab moved elsewhere tho ^^

I didn't get your point 3.2

Samekichi commented 4 years ago

3.2: When holding any upgrade and RC on a tank module, that module will be properly upgraded in display. However, if I then hold a water bucket and RC on that upgraded module, the bucket will become empty as expected, but the water level displays on the module will only increase for an instant and quickly disappear.

Rikshy commented 4 years ago

grafik

this is fine :D

Rikshy commented 4 years ago

only point 2 left sigh

Rikshy commented 4 years ago

@Samekichi do you know any mod who does the ghost item handling decently well?

Samekichi commented 4 years ago

Sorry I cannot recall one, but for storing recipes masa's Itemscroller has a simillar feature (placing items into crafting table or 2x2 in inventory as normal, and then press hotkey to register that recipe into Itemscroller's fast crafting recipe list), that's all I can think of = =

在 2020年9月2日,05:53,Rikshy notifications@github.com 写道:

 @Samekichi do you know any mod who does the ghost item handling decently well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Rikshy commented 4 years ago

i will releaase a new version with the current fixes, 2 is still open...