Riksrevisjonen / pioneeR

R package for running a Shiny app for DEA analysis
https://riksrevisjonen.github.io/pioneeR/
6 stars 2 forks source link

97 add s3 methods #103

Closed ohjakobsen closed 5 months ago

ohjakobsen commented 5 months ago

This PR adds S3 methods for class pioneer_bootstrap. It also adds support for NULL value for the ids argument in compute_dea(). In addition to this, this PR does the following:

The most "controversial" choice in this PR, is the support for excluding the need for the id argument in compute_dea(). This is done by setting id to NULL if the argument is missing. Without this, the function will fail if the user does not specify id, ie. compute_dea(data, input = c('col1', 'col2'), output = c('col3', 'col4')). However, this opens up the possibility of errors if the user relies on positional arguments, but skips id, ie. compute_dea(data, c('col1', 'col2'), c('col3', 'col4'), 'vrs')