14 upload module - Githubissues

Riksrevisjonen / pioneeR

R package for running a Shiny app for DEA analysis

https://riksrevisjonen.github.io/pioneeR/

8 stars 2 forks source link

14 upload module #28

Closed ohjakobsen closed 1 year ago

ohjakobsen commented 1 year ago

Added new upload module with slicker UI (data loads in a modal) and new functions (ability to change parameters after initial upload). The new upload functions are implemented as a Shiny module that can be reused within in the app, or later on, across apps.

lse81 commented 1 year ago

Great work, Ove. It seems I have to use some time to get familiar with the GitHub environment. I do not get the pull button to work. When I try the button in R, I get the following error message:

C:/Users/LSE/AppData/Local/Programs/Git/bin/git.exe pull kex_exchange_identification: read: Connection reset by peer fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

I do not know what is wrong (?) Maybe we can look at my setup in R tomorrow?

ohjakobsen commented 1 year ago

Great work, Ove. It seems I have to use some time to get familiar with the GitHub environment. I do not get the pull button to work. When I try the button in R, I get the following error message:

This is an SSL error that we can probably fix quite easily. Will look at this today.

ohjakobsen commented 1 year ago

'Enkoding' is misspelled.

When a file is selected the file input bar still shows "No file selected". Is that possible to change?

I get an error when uploading a sample .dta file that I have (attached)

It is not clear to me what the "Save" button does

I wonder if the "Close" button should be named "Done" ?

I'll look into these issues. A couple of comments:

The upload input is now standard Shiny, so I'm not sure how much we can change it without a lot of JS trickery
The "Save"-button actually saves the data to the session so that it can be used for analysis. The user must press the save button to accept the file
I'm not sure if "Done" is better than "Close". The reasoning here, is that you can close the modal without saving any changes

ohjakobsen commented 1 year ago

@Aeilert: I've added an explanation for the "Save" button + fixed some bugs in the file handling with 51afc52. I've tried to update the file input box with the name of the uploaded file. This should work out of the box with Bootstrap, but it seems that Shiny in some way or the other interferes with the input value. A fix would be to use the built in Shiny fileInput() function, but the UI for this is not very good, and only the button is clickable since Shiny uses text input instead of file input, making the UX far worse. I suggest we stick with the input as it is now, and see if we can debug Shiny at a later moment.

Aeilert commented 1 year ago

@ohjakobsen: Looks good. I have approved the PR.