Riksrevisjonen / pioneeR

R package for running a Shiny app for DEA analysis
https://riksrevisjonen.github.io/pioneeR/
8 stars 2 forks source link

Add fix for preview and checks for valid port numbers #43

Closed ohjakobsen closed 12 months ago

ohjakobsen commented 12 months ago

This PR resolves issue #39 and #40. The logic in reactive values for the DEA model has been reworked so that reactive values are not updated immediately. This should eliminate error messages in the console when the user uploads a new data set with different column names than the previous data set. New tests have also been introduced to the port argument of the run_pioneer function. Port numbers must be within the range 3000 through 65535, and not in the list of port numbers considered unsafe by Google Chrome. Previously, if an unsafe port was chosen, the app would start, but only show a blank page. In addition, this PR changes the following: