search

Riksrevisjonen / pioneeR

R package for running a Shiny app for DEA analysis
https://riksrevisjonen.github.io/pioneeR/
GNU General Public License v3.0
6 stars 2 forks source link

Add deprecation warning to `compute_scale_efficiency()` and `create_matrix()` #86

Open Aeilert opened 5 months ago

Aeilert commented 5 months ago

compute_scale_efficiency() should be re-written to align with either compute_efficiency() (as an internal function) or compute_dea() (as an exported function) or both.

We can start by deprecating the current version. 

  lifecycle::deprecate_warn(
    '0.5.0', 'compute_scale_efficiency()',
    details = 'compute_scale_efficiency() will be re-structured and receive breaking changes in a future release.')
ohjakobsen commented 5 months ago

Updated this issue to include create_matrix(). create_matrix() should be removed from server.R and deprecated. If we need a matrix helper function for server.R, this should be done as an internal function instead, and the exported function should still be deprecated.

ohjakobsen commented 3 weeks ago

As both functions are still used in our documentation and the report for reproducibility of the analysis within the app, we must postpone any deprecation of these functions. I will move this to our backlog.