Riksrevisjonen / pioneeR

R package for running a Shiny app for DEA analysis
https://riksrevisjonen.github.io/pioneeR/
6 stars 2 forks source link

87 rewrite pkg structure #92

Closed ohjakobsen closed 6 months ago

ohjakobsen commented 6 months ago

This PR moved all functions that earlier were put in ./inst/app and ./inst/app/R into ./R. This way, all internal functions should be available within the apps ui() and server() functions. To align with best practices for R packages and remove notes and warnings from R CMD check, several changes has been made:

This PR does not include new tests. New test should be written for most functions. However, the purpose of this PR is to move all functions out of ./inst/app. We should have a review of how functions can be optimised now that they are all internal functions. This should be a separate PR where we also introduce new tests.