search

RikudouSage / QrPaymentSK

QR payment generator for Slovak banks (the bysquare standard)
MIT License
29 stars 14 forks source link

treat variable/constant/specific symbols as strings #30

Closed ttibensky closed 3 years ago

ttibensky commented 3 years ago

There are symbols with leading zeros, e.g. 0308 https://www.mbank.sk/pomoc/info/ucty/zoznam-najpouzivanejsich-konstantnych-symbolov.html. If you treat it as an integer, the first zero will be ommited resulting in an incorrect symbol 308.

ttibensky commented 3 years ago

Here is a change proposal https://github.com/RikudouSage/QrPaymentSK/pull/31. You would also need to modify the documentation and perhaps do a new major release since this is a breaking change.

RikudouSage commented 3 years ago

Released as 4.0.0