search

RingOV / gis-weather

Customizable weather widget
58 stars 18 forks source link

Status Dropdown Menu for Indicator just like Gnome's Weather Indicator #30

Open pijulius opened 7 years ago

pijulius commented 7 years ago

Hi RingOV,

As I love what you did with this Gis-Weather widget (especially that it works with AccuWeather which is the most accurate one for my location) I would like to share my changes to the code, maybe someone (or even you) will find it useful.

Attached file contains

Download (as I'm not able to upload to github for some reason) http://pijulius.com/julius/gis-weather/gis-weather-indicator-dropdown-menu.zip

Stock icons will be used from the theme directory you choose for the indicator and if that directory doesn't exists it will fall back to default

The patch also will fix the position of the dropdown menus for the indicator to be correct ones (meaning open below the icon instead of over them depending where you mouse was when you clicked the icon).

Hope you will like/find these changes useful.

Regards, Julius

RingOV commented 7 years ago

Hi, Julius!

I was added your changes 2e1816d1e5b35bf9ae8ccf52100b946778397308 Needed testing

pijulius commented 7 years ago

Thanks Alexander!

I just downloaded the new build and everything seems to be working just fine, I see you also created stock icons for all themes and love the right click & select "Menu Icons" option, even better this way!

So for now all looks good, you even added mention to credits window so have no words :) I'm having this running now non stop so will let you know if there are any errors but so far love it and happy to see you found it useful afterall.

Regards, Julius