search

Ringloop / mr-plow

Minimal memory usage, cloud native logstash alternative
Apache License 2.0
28 stars 3 forks source link

json data parsing #30

Closed feed3r closed 2 years ago

feed3r commented 2 years ago

Still WIP, but I have implemented the parsing (and conversion) of the native query fields, related to #16

codecov-commenter commented 2 years ago

Codecov Report

Merging #30 (5b27b0c) into main (bc7fd18) will increase coverage by 7.19%. The diff coverage is 91.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   71.95%   79.15%   +7.19%     
==========================================
  Files           4        5       +1     
  Lines         271      379     +108     
==========================================
+ Hits          195      300     +105     
  Misses         42       42              
- Partials       34       37       +3
Impacted Files Coverage Δ
movedata/move.go 71.05% <86.20%> (+9.35%) :arrow_up:
casting/converter.go 93.18% <93.18%> (ø)
config/config.go 83.78% <100.00%> (ø)
elastic/indexer.go 73.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc7fd18...5b27b0c. Read the comment docs.

feed3r commented 2 years ago

I did almost all the required modifications, there are some open points and we need to implement some additional tests.

Anyway, if we agree on the modifications, we can then merge and plan a real world test

DarioBalinzo commented 2 years ago

I've approved, but there were conflicts with main. I tried to resolve the .gitignore conflict but now i see the test fail