- Remove test_util, it's not idiomatic looks like Java.

Ringloop / mr-plow

Minimal memory usage, cloud native logstash alternative

Apache License 2.0

28 stars 3 forks source link

- Remove test_util, it's not idiomatic looks like Java. #36

Closed giorgiozoppi closed 2 years ago

giorgiozoppi commented 2 years ago

inserted test package testify.
pending to integrate with elastic.

modified: ../go.mod modified: ../go.sum modified: complete_config_test.go modified: config_test.go modified: insert_integration_test.go modified: invalid_config_test.go modified: scheduling_integration_test.go modified: upsert_integration_test.go deleted: ../test_util/test_util.go

giorgiozoppi commented 2 years ago

I put in draft because i should check with an EC2 instance and elastic since i work on WSL now. Tomorrow i give it clue...i have also to understand how logstash works..

giorgiozoppi commented 2 years ago

Also tests doesnt' follow How to write code guidelines.

DarioBalinzo commented 2 years ago

Thank you for the suggestion! I will take a look soon..

Regarding logstash, I suggest to look at this jdbc input plugin to have an idea: https://www.elastic.co/guide/en/logstash/current/plugins-inputs-jdbc.html

giorgiozoppi commented 2 years ago

Thanks I will check, we need to meet us for a design session.

giorgiozoppi commented 2 years ago

We close this since it was included in the last one