[Fix] translate with strict falsy

RinkAttendant6 / JsonI18n

Simple PHP internationalization library using JSON data

Mozilla Public License 2.0

4 stars 1 forks source link

[Fix] translate with strict falsy #24

Closed NicolasRoehm closed 4 years ago

NicolasRoehm commented 4 years ago

Hi Vincent, can you review this issue please ? I really need that feature asap :)

RinkAttendant6 commented 4 years ago

All of the tests are currently failing, and this pull request does not explain what it is fixing since the previous tests were passing.

NicolasRoehm commented 4 years ago

I changed the location of the if (!$this->settings->getStrict()) statement because I failed the first implementation. I also added this condition to the _f function. Finally, I fixed the strict setting test.