search

Rinnegatamante / VitaDB-Downloader

Official VitaDB client for PSVITA/PSTV.
GNU General Public License v3.0
147 stars 3 forks source link

Crashes in first run if flight mode is on #21

Closed dekay closed 2 years ago

dekay commented 2 years ago

I installed VitaDB Downloader v.1.5 from a VPK file and data file downloaded from here. Tried to run it and it crashed as soon as it tried to download stuff. Tried a couple more times with the same result. Then noticed that I had flight mode on. Turned that off and and it downloaded all the png and other files successfully.

The .tmp file generated in ux0:/data says "Data abort exception", Thread name "VITADBBDLD", and cause "0x00030004"

A check for this with an appropriate error message is probably a good idea.

v-atamanenko commented 2 years ago

@dekay this application even has the word downloader in its title, which 100% implies that it needs internet connectivity to work. So launching it with flight mode on is something like turning on a PC with power cord not plugged in :)

But I'd maybe agree that for a wider range of internet connection-related issues (DNS issues, unreachable IPs, et cetera), ping 8.8.8.8 on startup with an error message in case of failure seems to be a good idea.

dekay commented 2 years ago

@v-atamanenko Right. But to follow your analogy, my PC doesn't blow up if I try to turn it on without the power cord plugged in :-)

In my case, I had flight mode turned on a long time ago and that didn't come to mind right away. All I had was the app crash on me a couple times. A simple check and a message to connect the dots would certainly be nice to have.

Rinnegatamante commented 2 years ago

Done with https://github.com/Rinnegatamante/VitaDB-Downloader/commit/027b48b2fa5dcdc8e70ab7c16e238fcb389199da