Rinnegatamante / VitaDB-Downloader

Official VitaDB client for PSVITA/PSTV.
GNU General Public License v3.0
147 stars 3 forks source link

Always states kubridge.skprx is outdated #30

Closed Sarkie closed 1 year ago

Sarkie commented 1 year ago

What's the latest version?

Where is it from?

It says it can download and restart console, so I do that, and it complains again.

Thanks!

Rinnegatamante commented 1 year ago

Do you have a franken config.txt? (Both in ur0 and ux0)

Sarkie commented 1 year ago

Nope, and the file is updated, I can see the update date as yesterday.

Just in ur0

Sarkie commented 1 year ago

Want me to upload the .cfg?

How is it checking the date? via md5 or similar?

Rinnegatamante commented 1 year ago

via checksum of the skprx against the cheskum on VitaDB. First it checks where it is (assuming you don't have it in both ur0 and ux0: https://github.com/Rinnegatamante/VitaDB-Downloader/blob/main/source/main.cpp#L1319-L1321 Then checksums it: https://github.com/Rinnegatamante/VitaDB-Downloader/blob/main/source/main.cpp#L1995-L1997 Then queries VitaDB for its hash: https://github.com/Rinnegatamante/VitaDB-Downloader/blob/176d6af9997bc611f82b5d3e775504a6d97de393/source/main.cpp#L1998 And if it detects hash discrepancy, asks for update: https://github.com/Rinnegatamante/VitaDB-Downloader/blob/176d6af9997bc611f82b5d3e775504a6d97de393/source/main.cpp#L1999-L2003

Sarkie commented 1 year ago

Ok let get the one off disk and compare the hash to see what's going on

Sarkie commented 1 year ago

I have no idea.

I downloaded the file and then compared it to https://github.com/bythos14/kubridge/releases

Both have MD5 of 30841f4e8f4ee0ed27e70a4c79c7c695

But if I check https://vitadb.rinnegatamante.it/get_hb_hash.php?id=611

That returns d41d8cd98f00b204e9800998ecf8427e

Is that meant to be MD5?

Rinnegatamante commented 1 year ago

Seems like it's an issue with VitaDB host. They silently updated something in PHP installation which makes all file reads fail now. I'll look into it.

Rinnegatamante commented 1 year ago

Should be fixed now.

Sarkie commented 1 year ago

LGTM .

How come I was the only person complaining about this?

pmsobrado commented 1 year ago

Forgive me if I say something stupid, but, since some apps share their ID, could you implement something like this?

1 - Get installed app ID 2 - Check that ID on VitaDB (it may be one, or it may be more than one) 3 - Get all VitaDB checksums for that ID 4 - Compare against local installed app 5 - If one of them matches, the app must be updated, because, as I see it, if more than one app has the same ID on VitaDB it is because of the different authors giving it that ID, and that can be the only case, since I guess VitaDB doesn't have more than one latest version per app.

I was wondering, why not compare the version number? Maybe that info isn't given? Or build/modified date or something like that?

Also, I have detected some outdated apps on VitaDB, where can I report this so the database can be updated?

Thanks.

Rinnegatamante commented 1 year ago

"5 - If one of them matches, the app must be updated, because, as I see it, if more than one app has the same ID on VitaDB it is because of the different authors giving it that ID, and that can be the only case, since I guess VitaDB doesn't have more than one latest version per app."

That's not the case since apps can have both a nightly and a stable release both on VitaDB.

pmsobrado commented 1 year ago

That's a shame. Further implementations could be done, like flagging apps as nightly and such, giving the user the option... but never mind. What about my other question, regarding where can I report outdated apps on VitaDB database?

Thanks!

Rinnegatamante commented 1 year ago

Vita Nuova Discord Server has a dedicated channel for VitaDB: https://discord.gg/PyCaBx9

pmsobrado commented 1 year ago

Yes, I have asked there. Thanks!

pmsobrado commented 1 year ago

By the way, would be hard to implement a blacklist for homebrew, so the ones that have the outdated issues or the same titleid issues can be skipped?

Thanks.

Rinnegatamante commented 1 year ago

The daemon already has a blacklist. As for the app, there are themes which have the Outdated tag fully transparent (so hidden).

pmsobrado commented 1 year ago

Ok, thanks.