Rinnegatamante / vitaQuakeII

Quake II port for PSVITA.
GNU General Public License v2.0
52 stars 27 forks source link

Adding ur0:/ support for "data" directory #19

Closed kamilb880 closed 5 years ago

kamilb880 commented 5 years ago

It will be cool to have possibility to use ur0:/ partition as source for data directory - it takes most of the space that homebrew uses, and many users will be glad to have that option

Rinnegatamante commented 5 years ago

I think ur0: support would actually require the game to be compiled as un unsafe homebrew (don't think it's worth it). However uma0: support could be added.

kamilb880 commented 5 years ago

Got it. If you want the confirmation, if it will require unsafe homebrew compilation I can be a tester to be sure. Just let me know

kamilb880 commented 5 years ago

Or, if it is just a simple modification to achieve, can you just implement it with adnotation that it will work only when self compiling as unsafe homebrew?

Rinnegatamante commented 5 years ago

You would still need vitasdk set with vitaGL and all other dependencies to compile it.

kamilb880 commented 5 years ago

I'll compile it by myself as unsafe homebrew, just to test if ur0: feature is working fine. If this is not a huge deal for you to add this option - as mentioned above, with adnotation that it will work only when self compiling from source - I'd gladly be your tester.

kamilb880 commented 5 years ago

Just one additional thing has crossed my mind. Could you add possibility to use imc0: as space for "data" dir? Just like you have mentioned adding uma0 support. It will not require app to be compiled as unsafe homebrew, and we'll be able to use Vita's internal storage (even on Vita 1xxx with IMCUnlock).

Rinnegatamante commented 5 years ago

I don't think imc0 is any different from ur0.

Rinnegatamante commented 5 years ago

uma0 support had been added with https://github.com/Rinnegatamante/vitaQuakeII/commit/82ef38eab2f5baf0e19f61e119b097fee3bd3746 . If you're willing to check ur0 with unsafe, should be easy to work on that code.

kamilb880 commented 5 years ago

Cool, thanks. I'll give it a try. But regarding imc0 - it is treated by Vita as additional memory card (just like uma0), so why do you think it will be also treated as system partition, like ur0? If uma0 doesn't require "unsafe homebrew" permission, then with imc0 should be the same?

Rinnegatamante commented 5 years ago

You can try to replace uma0 code with imc0 and see if it works but i'm almost sure it won't.