- Fixed closable alert missing title issue

RinteRface / bs4Dash

Bootstrap 4 shinydashboard using AdminLTE3

https://bs4dash.rinterface.com

Other

441 stars 81 forks source link

- Fixed closable alert missing title issue #357

Closed MohammedFCIS closed 1 year ago

MohammedFCIS commented 1 year ago

Hi I found that solution for https://github.com/RinteRface/bs4Dash/issues/315 was overwritten as it addressed the inst files only. So, here I updated src js file as well Thank you

MohammedFCIS commented 1 year ago

Hi @DivadNojnarg - Thanks for updating PR target branch but I noticed that:

Now we have conflicts
Also, bs4Dash-2.4.0.9000 folders exist instead of bs4Dash-2.3.0

So, should I cancel this PR and submit new one to the new version? Thanks for your guidance Best regards,

DivadNojnarg commented 1 year ago

Yes sorry about this. I should add some instructions for contributing. You can cancel this PR and redo it on dev where the right folders exist bs4Dash-2.4.0.9000.