RinteRface / shinybulma

🌐 Bulma.io for Shiny
https://rinterface.github.io/shinybulma/
Other
111 stars 15 forks source link

Container #12

Closed JohnCoene closed 5 years ago

JohnCoene commented 5 years ago

I'm using shinybulma for echarts4r shiny demo and noticed that the container has no effect if, as described in the official docs, it is not a child of:

Though it's fine if one is aware it's rather counter-intuitive for the regular Shiny user, perhaps section should automatically add a container?

DivadNojnarg commented 5 years ago

What do you suggest:

JohnCoene commented 5 years ago

Well, I'm personally unsure. I think keeping them separate is good in the event a user does not want a container. Perhaps adding an argument container which defaults to TRUE in bulmaSection? What do you reckon?

DivadNojnarg commented 5 years ago

bulma-footer has a container argument as well. Therefore, we could do like that!

JohnCoene commented 5 years ago

Great! I'll take of it.

JohnCoene commented 5 years ago

Done.