RinteRface / shinydashboardPlus

extensions for shinydashboard
https://shinydashboardplus.rinterface.com
Other
454 stars 77 forks source link

Left sidebar collapse/expand icon #39

Closed DavidPatShuiFong closed 5 years ago

DavidPatShuiFong commented 5 years ago

I find there is a problem with the collapse/expand icon for the left sidebar. This is what it looks like, for shinydashboardPlus 0.7.5, using shinydashboardPlusGallery() and using Microsoft Windows 10.

With Edge 42.17134.1.0:

image

With Firefox 67.0:

image

and probably what it is supposed to look like, in Chrome 74.0.3729.169:

image

DivadNojnarg commented 5 years ago

Hi @DavidPatShuiFong: which version of shiny are you currently using?

Could you do the following for me (see image below):

Capture d’écran 2019-06-03 à 19 17 56

My guess is that the class would be something like "fas fa-bars" instead of "fa fa-bars"...

DavidPatShuiFong commented 5 years ago

My apologies, the version of shinydashboard I was using was 0.7.0, and the version of shiny was 1.3.0 (this was a MRAN snaphsot for Microsoft R Open 3.5.1, not the first time I've been caught out by older packages).

The problem was fixed in shinydashboard 0.7.1, as reference in https://github.com/rstudio/shinydashboard/issues/297

Upgrading to shinydashboard 0.7.1 fixed the missing hamburger problem. My apologies for the false alarm!

DavidPatShuiFong commented 5 years ago

Hi @DavidPatShuiFong: which version of shiny are you currently using?

Could you do the following for me (see image below):

* open the web inspector and give me the class of the sidebar toggle icon.
Capture d’écran 2019-06-03 à 19 17 56

My guess is that the class would be something like "fas fa-bars" instead of "fa fa-bars"...

image

it was "fa fa-bars" (with shinydashboard 0.7.0, which I'm going to upgrade to 0.7.1 on this computer real soon...)