search

RiotGames / LoRDeckCodes

Other
158 stars 46 forks source link

Update README.md #58

Closed stelar7 closed 3 years ago

Billzabob commented 3 years ago

Wouldn't adding support for version 3 before it's released break your encoder? It'll encode decks with 3 for the version which the game currently sees as invalid. I ask because I'm curious how I should handle this myself.

RiotTuxedo commented 3 years ago

@Billzabob yes it would, this is why we'll be merging our PR on the day the expansion is released.

Billzabob commented 3 years ago

@RiotTuxedo Gotcha. I'll make a PR to add my own lib to the README then. I'll be updating it to version 3 on release day 👍

Billzabob commented 3 years ago

@RiotTuxedo Or should I just add it to this PR?

RiotTuxedo commented 3 years ago

Either or. I'll be going through the existing libraries day of and a couple days after to see which ones updated to version 3.