Add Varint and README code unit tests

[ed-flanagan]

This PR has a couple of changes, split out across commits. Happy to drop/split out any commits if felt PR is too big.

• Add unit tests for VarintTranslator methods
  • AFAICT, the current Varint implementation is unsigned LEB128, reading least significant bytes first
  • Impl references https://github.com/topas/VarintBitConverter, which references https://developers.google.com/protocol-buffers/docs/encoding#varints
  • Update the root README to reflect current impl, i.e. little endian
  • Add unit tests for valid and invalid byte sequences
• Update README deck code example
  • Update README deck code to reflect current sorting strategy. The set/faction orders were flipped.
  • Add to unit test data file
• Visual studio code auto-formatted some existing code in UnitTest1.cs
• Update LoRDeckCodes_Tests.csproj ProjectReference (s/Lor/LoR/)
• Opinionated:
  • Re-ordered UnitTest1.cs using directives
  • Removed unused Newtonsoft.Json package
  • Removed byte order mark from tracked files
  • Try to make *.csproj spacing consistent
  • Update netcoreapp to v3.1
    • netcoreapp2.0 used in both projects. This version is EOL. Update the LTS version 3.1 (2022-12-03)
    • Resolves Package warning message: warning NETSDK1138: The target framework 'netcoreapp2.0' is out of support and will not receive security updates in the future.
    • Happy to update to .NET 6, but figured this was the smallest jump https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

[ed-flanagan]

@RiotTuxedo 👋 sorry for the ping. I saw others do it and this PR has been sitting for a while. Any thoughts? I can rebase with recent changes that merged, but general idea’s the same

[RiotTuxedo]

Hey ed,

I'm focusing mainly on helping to keep the documentation up-to-date. The lor engineers handle updating the repo with the logic to support new deck codes and the tests. They'd have to review your changes and decide if they want to accept it into the code. I'll let one of them know there's an open PR, but there's no guarantees they'd have time to review and merge it.

[ed-flanagan]

👍 sg, no worries. I was looking at changes in https://github.com/RiotGames/LoRDeckCodes/pull/88 which had some small overlap, so figured I’d check in.

[RiotTuxedo]

Ah makes sense. That's one of the lor devs that didn't have access to merge the changes for the latest set.

[ed-flanagan]

Ah right on, appreciate the context - sorry again for the ping