search

RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
747 stars 44 forks source link

[BUG] Incorrect documentation for bountyGold in match-v5 ChallengesDto #1005

Open ckousik opened 3 weeks ago

ckousik commented 3 weeks ago

Bug Description
Error in Match-v5 ChallengesDto documentation

Problem Description
bountyGold is documented as an integer but it can be a float.

Expected Result
Documentation is out of date/inconsistent.

Actual Result
bountyGold should be documented as a float.

Developer Impact
Type deserializers generated from the API spec will fail, especially for strongly typed languages.

Repro Steps
Query match-v5 endpoint for LA1_1568057368. bountyGold for one of the Participant structs is a float.

ckousik commented 3 weeks ago

Is related to https://github.com/RiotGames/developer-relations/issues/982

MingweiSamuel commented 2 weeks ago

Seems like the data is bugged, why would gold bounty ever be fractional? Did they change how bounty gold works?

(docs should be updated regardless, with note perhaps)

noahkohrs commented 2 weeks ago

Totally agree, it actually affect few other fields in some really specific games.

ckousik commented 2 weeks ago

Seems like the data is wrong, why would gold bounty ever be fractional? Did they change how bounty gold works?

I double checked this. In LA1_1568057368, please see the Participant data for player with game name "Zelt" and tagline "GGZ". Their bountyGold is 17.56436538696289

MingweiSamuel commented 2 weeks ago

@noahkohrs What are the match IDs?