RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
739 stars 44 forks source link

/lol/match/v4/matches/{matchId} should contain the player uuid #122

Closed alvarotuso closed 1 year ago

alvarotuso commented 5 years ago

In the participant_identities list, we can find the summoner names and account ids, both current and original, but the puuid is not included. It would be ideal to have this information available in the same endpoint to avoid a subsequent call to SUMMONER-V4 to get it.

Example current response:

{
  "participantIdentities": [
    {
      "participantId": 1,
      "player": {
        "platformId": "LA2",
        "accountId": "0OumLRWgnihKGAHxV5eoOPf3TsonfqjS99BnOjU5QJPcQmQ",
        "summonerName": "TmAEcko",
        "summonerId": "khLIpQg02WUTe3uJ5HC5uctJSq5OaB5f_U4_oQ5VIBKa9DE",
        "currentPlatformId": "LA2",
        "currentAccountId": "0OumLRWgnihKGAHxV5eoOPf3TsonfqjS99BnOjU5QJPcQmQ",
        "matchHistoryUri": "/v1/stats/player_history/LA2/200565934",
        "profileIcon": 3505
      }
    }
  ]
}

Suggested improvement:

{
  "participantIdentities": [
    {
      "participantId": 1,
      "player": {
        "platformId": "LA2",
        "accountId": "0OumLRWgnihKGAHxV5eoOPf3TsonfqjS99BnOjU5QJPcQmQ",
        "summonerName": "TmAEcko",
        "summonerId": "khLIpQg02WUTe3uJ5HC5uctJSq5OaB5f_U4_oQ5VIBKa9DE",
        "currentPlatformId": "LA2",
        "currentAccountId": "0OumLRWgnihKGAHxV5eoOPf3TsonfqjS99BnOjU5QJPcQmQ",
        "matchHistoryUri": "/v1/stats/player_history/LA2/200565934",
        "profileIcon": 3505,
        "puuid": "encryptedPUUID", // Include PUUID to conform to the v4 universal identifier
      }
    }
  ]
}
RiotTuxedo commented 5 years ago

For context, the match service was created before puuids were added. The work to add this data into match history would have to get prioritized. We'll look into this, but for the foreseeable future you'll need to continue making two separate API calls.

alvarotuso commented 5 years ago

No problem, thanks for taking a look!

tisbells commented 1 year ago

Closing out old issues. Match-v4 is no longer supported. Feel free to reopen/comment if you feel this is in error.