search

RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
746 stars 44 forks source link

[BUG] (Reopening) Spectator/active-game endpoint returning 404 whereas the player is ingame #165

Closed trebonius0 closed 4 years ago

trebonius0 commented 5 years ago

Hey guys

(Reopening https://github.com/RiotGames/developer-relations/issues/136)

Since the 9.19 release, I've got multiple reports of spectator endpoint in OCE returning http404 whereas the player was ingame.

Currently, it's affecting about 40% of the lookups in OCE.

Could you have a look please ?

Thanks :)

RiotR1cket commented 5 years ago

Hi, I'm an engineer on the team that owns spectator, I saw your message yesterday morning and fixed the issue with our OCE spectator grid (approx 9am PST). Thanks for reporting it! We're still working through the root cause so if you see it again please don't hesitate to reopen this or the other ticket.

RiotTuxedo commented 5 years ago

@trebonius0 has this issue been resolved for you?

trebonius0 commented 5 years ago

Yes :)

cohenu commented 5 years ago

is it back since the last patch ?

RiotTuxedo commented 5 years ago

This looks to be an unrelated issue. It's affecting a couple services. We're looking into it. https://twitter.com/RiotGamesAPI/status/1187080155434323968

RiotTuxedo commented 5 years ago

@cohenu sorry let me double check something. What kind of errors are you seeing with spectator and in what regions were you seeing them?

cohenu commented 5 years ago

@RiotTuxedo I'm sorry for the delay, Riot API key usage shows on Spectator:

EUN1: 403: 32,468 200: 15,060 404: 1,628 503: 242 500: 35

EUW1: 403: 59,624 200: 35,198 404: 2,625 503: 609

NA: 200: 127,860 404: 9,879

TR1: 403: 26,916 200: 17,272 404: 832 503: 278 500: 60

BR1: 200: 3,403 404: 432

OC1: 200: 18,118 404: 1,541 500: 9

RU: 403: 2,175 200: 1,195 404: 121 503: 12

LA1: 200: 4,690 404: 291

LA2: 200: 3,468 404: 194

I hope this helps

RiotR1cket commented 5 years ago

@cohenu Our metrics show euw/eun/tr/ru have no more 403 responses as of 21 hours ago, let us know if you don't see the same in your metrics.

cohenu commented 5 years ago

@RiotR1cket I checked now and the numbers are not growing - I will check again tomorrow and update Thank you very much guys :)

cohenu commented 5 years ago

@RiotR1cket I didn't find any 403 today :) Thank you!

davews156 commented 5 years ago

We are getting this today as of about 3 hours ago (5:30 ET) to now. Discord folks recommended we reopen this issue.

We are currently getting a lot of 403s back. The Spectator API Usage metrics do NOT show 403s, but we are getting them and a lot of them. Here are a few examples of Summoner Name, Region, and Timestamp:

Varadon (euw1, Mon, 28 Oct 2019 23:56:07 GMT) CrafteurGaming (euw1, Mon, 28 Oct 2019 23:57:13 GMT) GG Rhaykko (euw1, Mon, 28 Oct 2019 23:58:07 GMT) Wazabie (eun1, Mon, 28 Oct 2019 23:51:20 GMT)

MingweiSamuel commented 5 years ago

403 would indicate your API key/authentication failed, so they wouldn't show up in the portal. What % of responses are you getting as 403?

trebonius0 commented 5 years ago

I've the same issue here

100% of my spectator calls to EUW/EUNE/RU/TR are returning 403 Other regions seem to be ok

chypriote commented 5 years ago

Same issue here, getting 403 on EUW with both the production key and a newly generated dev key

davews156 commented 5 years ago

403 would indicate your API key/authentication failed, so they wouldn't show up in the portal. What % of responses are you getting as 403?

Hard to say exactly, but about 250 of them in 30 minutes so I'd say at least half. They do seem to be European regions.

cohenu commented 5 years ago

I also have issues with spectator endpoint. I didn't see 403 in API KEY USAGE but I see 403 when I try to send request to spectator endpoint on a live custom game (ALLOW SPECTATORS = All, I'm using custom game only for testing, users complains on normal and ranked queues too, I'm using production key.)

trebonius0 commented 5 years ago

@RiotTuxedo any update ?

RiotTuxedo commented 5 years ago

Yep, we're aware and looking into it, but I would like to separate these issues. There's three issues being conflated here:

  1. The original issue was related to active players in-game returning 404 responses.
  2. Then there was an issue where 500s and 503s were being returned from the API.
  3. Now there's an issue where 403s are being returned from the API.

I believe all three of these are indicative of separate issues and it's a little confusing when someone says "same" which issue is affecting them. For now, let's limit the conversation in this thread to issue 1 and let's open a separate issue for point 3. I believe point 2 should be resolved at this point.

trebonius0 commented 5 years ago

Yeah sorry, my bad. I'm opening another thread for the http 403 :)