search

RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
742 stars 44 forks source link

[REQUEST] League of Legends Live Game API should have a champion ID or key for all players #360

Open Querijn opened 4 years ago

Querijn commented 4 years ago

Bug Description
League of Legends Live Game does not contain either Champion IDs or Champion Keys for current game API.

Problem Description
In the ingame api, it's hard to identify champions against DDragon or alternative, as the only data you have for those is the championName and the rawChampionName. This is kind of a trap, as the championName is localised to the client's current locale, meaning that you can't use it to match the DDragon name in the cases outside of english locales. You can't request the locale either.

Preferred Change
An extra member is added to allPlayers and activePlayer, which is the champion id or champion key.

Developer Impact You can potentially hack your way around it by lowercasing the ddragon ids and the current rawChampionName, cutting it up at the _ and taking just the last part.

Player Impact Zero.

Preconditions Requires Live Game API not to be bugged

Repro Steps

  1. Go into game
  2. Check the result from https://localhost:2999/liveclientdata/allgamedata
Querijn commented 3 years ago

This expands to other displayNames too, for instance spells.