RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
742 stars 44 forks source link

[BUG] attackSpeed value in championStats (MatchV5 Timeline) is faulty/misleading #526

Closed citrito closed 3 years ago

citrito commented 3 years ago

Bug Description
attackSpeed value in championStats (included in MatchV5 timeline endpoint) is unclear

Problem Description

Expected Result

DoctressWasTaken commented 3 years ago

Attackspeed is always calculated against the base attackspeed of the champion.

Its not like other stats that get added to the baseline when leveling up.

e.g. Cait will have 0.7 base attackspeed at lvl 1 and 0.7 base attackspeed at lvl 18. But she will have +120% attackspeed from levels.

Thats why everything you buy or have in runes is bonus attackspeed.

citrito commented 3 years ago

@LightshieldDotDev Thanks for the insight. Then I am still left wondering why the attack speed rune shard does not have any effect on the shown value. Does the first frame represent the champions in their "raw" state?

DoctressWasTaken commented 3 years ago

Good point, can you give me the matchId for one of the games you looked at?

citrito commented 3 years ago

@LightshieldDotDev Sure! Hope this helps

DoctressWasTaken commented 3 years ago

Ye, seems to not include runes in the first frame. He has 113 in the second frame which would account for lvl 2 + the rune

RiotTuxedo commented 3 years ago

The first frame is the starting state for the players. The frame after is the best frame to determine the starting state after modifiers are applied.

citrito commented 3 years ago

@LightshieldDotDev Could eventually determine the starting AS value from the lvl 2 value if the second frame jumps straight to it. Thanks for looking into this

@RiotTuxedo Thanks for the hint and clarifying this