search

RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
743 stars 44 forks source link

[BUG] TFT Sniper / Scholar emblems got same ID #567

Closed Floliroy closed 1 year ago

Floliroy commented 2 years ago

Hi, found a bug on the TFT-MATCH api : Scholar emblem and Sniper emblem got the exact same ID so there is no way to know from the ID in the api answer which ID is which item.

Proof from https://raw.communitydragon.org/11.22/cdragon/tft/en_us.json : image_2021-11-04_034931 image_2021-11-04_034937

Floliroy commented 2 years ago

Still not fixed on new patch https://raw.communitydragon.org/11.23/cdragon/tft/en_us.json

Querijn commented 2 years ago

Heya, it might help evaluating the issue's importance if you could explain how this impacts your application. Does it block you from making a feature? Is the output incorrect? Is there a way around it?

Actually, just noticed you cited communitydragon. That's not an official Riot product, and is managed by a third party.

Floliroy commented 2 years ago

Hi, i want to create a post game image displaying units with their items and traits for all player in the game (a bit like lolchess does). And so as items are stored by their IDs in the TFT-MATCH api, i cant know if the unit have scholar or sniper emblem cause it is the same ID.

Querijn commented 2 years ago

I've edited my comment to add more information, and I feel like you've missed it: raw.communitydragon.org is not a Riot Games product, and therefore is not up to them to fix it. You're better off posting in the CDragon Discord: https://discord.gg/yNFG5yk

Even if it's based on TFT's internal game files, It's unlikely your problem is given any sort of priority to fix it, so I recommend hotfixing it on your side.

Floliroy commented 2 years ago

What i mean is that even on TFT-MATCH api the ID are the same for both emblems (i checked it), so yeah it is a minor bug, but it is a bug i guess. Except if you think its legit that an ID isnt unique.

Pyrrian commented 2 years ago

I see this bug is also impacting their own client. (29-11-2021) image

mikaeldui commented 2 years ago

I see this bug is also impacting their own client. (29-11-2021) image

What's wrong with Sniper Taric?

Floliroy commented 2 years ago

I see this bug is also impacting their own client. (29-11-2021) image

What's wrong with Sniper Taric?

He used a scholar spat on taric

lucasMesquitaBorges commented 1 year ago

Hi, Issue not related to the Riot API. Feel free to re-open if related directly with the TFT Riot API.