search

RiotGames / developer-relations

Riot Games Developer Ecosystem Bug Reporting
http://developer.riotgames.com
744 stars 44 forks source link

[BUG] `lol-challenges-v1` Apex tier issues #640

Open aPinat opened 2 years ago

aPinat commented 2 years ago

Description

  1. First off, unsure if intended, but the whole endpoint blocks Development API Keys from being used.

  2. For /lol/challenges/v1/challenges/{challengeId}/leaderboards/by-level/{level} the selector for {level} currently contains NONE, IRON, BRONZE, SILVER, GOLD, PLATINUM, DIAMOND, MASTER, GRANDMASTER, CHALLENGER, HIGHEST_NOT_LEADERBOARD_ONLY, HIGHEST, LOWEST but only MASTER, GRANDMASTER, CHALLENGER as apex tiers appear to be usable and probably also only those intended to be used. Maybe those work on LEdge /challenges-client/v2 or is a relic from /challenges-client/v1, but I have yet to find that endpoint there :-P

  3. The same endpoint has a limit param, which works, but caps out at 1000 entries, however most leaderboards with have way more entries. For example the "DPS Threat" with id 101101 currently have their leaderboards start at number 1/745/3717 for Challenger/Grandmaster/Master respectively. Me currently being number 1212 of GM in the LCU, means I'm number 1212+745 on the leaderboard and also not visible. Perhaps we could get a page or start optional param?

  4. This one is more of an underlying service issue since it impacts the display in the LCU and is confusing for players as well as an inaccuracy in the developer API: Since apex tier thresholds are dynamic by nature, I feel those should be updated in the /config when apex tiers are updated every night so players know what the current threshold is to promote into the next tier and for it to be matching the leaderboard API as well. Going by the example above, the threshold to promote to GM is 15, however in reality that is not enough to promote, because with 15 you would still be Master since the actual threshold is at 16 at the moment.

Expected Result

  1. Getting successful responses from those endpoints.
  2. Either all level working or have them not show up.
  3. Being able to find players on the leaderboard that are over 1000 in their respective tier.
  4. Getting accurate thresholds for Apex tiers.

Actual Result

  1. 403 Forbidden.
  2. Errors for enum values that are not MASTER, GRANDMASTER, CHALLENGER.
  3. Limit caps at 1000 with no way to get players below that.
  4. Apex tier thresholds don't match the leaderboard or what a player needs to achieve.
geozukunft commented 2 years ago
  1. That is intentional
  2. See #633
aPinat commented 2 years ago

Oh, I'm blind; not sure how I didn't see your issue...

I'll just leave this open for reference for now and mostly for point 3. Point 4 is out scope for dev-rel, but I did reference this issue in the PBR, so...

geozukunft commented 2 years ago

Bumping that point .4 is still an issue and renders the /config endpoint kinda useless